Signed orders API #139
Merged
Signed orders API #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atvanguard
force-pushed
the
signed-orders
branch
from
689a812 to
279a5fe
Compare
atvanguard
force-pushed
the
create-order
branch
from
69e47f8 to
2ad89aa
Compare
lumos42
approved these changes
Dec 29, 2023
|
|
||
| const ( | ||
| Limit OrderType = iota | ||
| IOC | ||
| Limit = hu.Limit |
There was a problem hiding this comment.
is this to keep it compatible with existing data in memory db?
There was a problem hiding this comment.
Moved the data structures to hu. but a lot of code was referencing Limit directly from this package.
|
|
||
| // Trading API methods | ||
|
|
||
| // func (o *SignedOrder) UnmarshalJSON(data []byte) error { |
There was a problem hiding this comment.
Used this earlier, but now I changed encoding from json to abo encoded
atvanguard
added a commit
that referenced
this pull request
Jan 9, 2024
* tradingApi.PostOrder * start modifying precompile * all validations! * stash * fix unit tests * trading_postOrder API works 🎉 * misc * Matching works! * chainid and verifying contract * stash * fix test * resolve shubhams comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
jurorv2that adds functionality to match signed orders with any other order typeAccompanying contracts PR - https://github.com/hubble-exchange/hubble-protocol/pull/214